Improved painless error toasts #91346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
|
@elasticmachine merge upstream |
…e/kibana into improved_painless_error_toasts_c
mattkime
added
release_note:skip
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
mattkime
added
Feature:Search
…e/kibana into improved_painless_error_toasts_c
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Feb 18, 2021
* better painless error modal
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
mattkime
added a commit
that referenced
this pull request
Feb 19, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A painless script failed while performing a query. Why?
Before -
After -
to test
edit
src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsxon line 801 set
isValidto true and disable the next five lines that were part of the assignment.now you can write bad painless that will easily return errors!